Andrew Nicols [Tue, 26 May 2020 03:05:56 +0000 (11:05 +0800)]
MDL-68750 tool_dataprivacy: Correct behat test modal checks
Andrew Nicols [Tue, 26 May 2020 03:05:47 +0000 (11:05 +0800)]
MDL-68750 analytics: Correct behat test modal checks
Andrew Nicols [Tue, 26 May 2020 02:55:12 +0000 (10:55 +0800)]
MDL-68750 core_tag: Add missing confirmation dialogue title
Andrew Nicols [Sun, 17 May 2020 06:09:01 +0000 (14:09 +0800)]
MDL-68750 behat: Correct dialogue selector
Victor Deniz Falcon [Fri, 22 May 2020 13:21:37 +0000 (14:21 +0100)]
weekly release 3.9dev+
Victor Deniz Falcon [Fri, 22 May 2020 13:21:32 +0000 (14:21 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jake Dallimore [Fri, 22 May 2020 07:10:04 +0000 (15:10 +0800)]
Merge branch 'MDL-68367-master-fix' of git://github.com/junpataleta/moodle
Jun Pataleta [Fri, 22 May 2020 06:45:05 +0000 (14:45 +0800)]
MDL-68367 qtype_multichoice: Decrease minimum expected export file size
* Exporting via Oracle trims trailing zeroes in floating numbers which
results to a smaller file size for the exported file. Better to reduce
the minimum expected export file size from 4000 bytes to 3900 bytes.
Andrew Nicols [Fri, 22 May 2020 03:53:22 +0000 (11:53 +0800)]
Merge branch '68137-master-prevent-removing-all-dots-in-filename' of https://github.com/DSI-Universite-Rennes2/moodle
Jake Dallimore [Fri, 22 May 2020 03:52:31 +0000 (11:52 +0800)]
Merge branch 'MDL-68143-master' of https://github.com/HuongNV13/moodle
Jun Pataleta [Fri, 22 May 2020 03:50:53 +0000 (11:50 +0800)]
Merge branch 'MDL-65796' of https://github.com/paulholden/moodle
Andrew Nicols [Fri, 22 May 2020 03:37:38 +0000 (11:37 +0800)]
Merge branch 'MDL-57240' of https://github.com/timhunt/moodle
Andrew Nicols [Fri, 22 May 2020 03:32:01 +0000 (11:32 +0800)]
Merge branch 'MDL-68446' of https://github.com/timhunt/moodle
Andrew Nicols [Fri, 22 May 2020 03:21:47 +0000 (11:21 +0800)]
Merge branch 'MDL-68783-master' of git://github.com/junpataleta/moodle
Andrew Nicols [Fri, 22 May 2020 03:12:46 +0000 (11:12 +0800)]
Merge branch 'MDL-68661-rebase' of https://github.com/Chocolate-lightning/moodle
Jun Pataleta [Fri, 22 May 2020 03:06:16 +0000 (11:06 +0800)]
Merge branch 'MDL-68508-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Fri, 22 May 2020 02:51:31 +0000 (10:51 +0800)]
Merge branch 'MDL-67700-master' of git://github.com/ferranrecio/moodle
Andrew Nicols [Fri, 24 Apr 2020 08:08:45 +0000 (16:08 +0800)]
MDL-68508 core_table: Improve sorting to support sorting by multiple columns
Jake Dallimore [Fri, 22 May 2020 02:35:27 +0000 (10:35 +0800)]
Merge branch 'MDL-58645-master' of https://github.com/HuongNV13/moodle
Mathew May [Mon, 18 May 2020 05:25:45 +0000 (13:25 +0800)]
MDL-68661 core_lang: Roll back addresourceoractivity
Andrew Nicols [Fri, 22 May 2020 01:21:21 +0000 (09:21 +0800)]
MDL-68493 contentbank: Whitespace fixes
Andrew Nicols [Fri, 22 May 2020 01:04:57 +0000 (09:04 +0800)]
Merge branch 'MDL-68493-master' of git://github.com/bmbrands/moodle
Eloy Lafuente (stronk7) [Fri, 22 May 2020 00:15:03 +0000 (02:15 +0200)]
Merge branch 'MDL-65306-resourceid-onecommit' of https://github.com/cengage/moodle
Victor Deniz Falcon [Thu, 21 May 2020 21:28:32 +0000 (22:28 +0100)]
Merge branch 'MDL-39571-Master' of git://github.com/tuanngocnguyen/moodle
David Mudrák [Tue, 19 May 2020 21:01:16 +0000 (23:01 +0200)]
MDL-68738 wiki: Prevent URLs inside links from turning into another link
There was a problem with wiki pages in the HTML markup syntax. If they
contain a link and the link text has a URL in it, that URL was converted
into another link. But it was not correctly nested and it caused
additional troubles with filters (particularly the multimedia filter if
the URL was a video such as on youtube).
The solution here is similar to what we do in filters. We protect the
whole explicit link so that its content is not further parsed. That
prevents the inner URL to be converted into another link and the
explicit link has the full control.
Sara Arjona [Thu, 21 May 2020 17:00:01 +0000 (19:00 +0200)]
Merge branch 'master_MDL-67497' of https://github.com/danmarsden/moodle
Ferran Recio [Thu, 21 May 2020 13:26:52 +0000 (15:26 +0200)]
MDL-67700 message: prevent async loading conversation message mix
Sara Arjona [Thu, 21 May 2020 15:33:12 +0000 (17:33 +0200)]
Merge branch 'MDL-66471' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 21 May 2020 12:30:13 +0000 (20:30 +0800)]
Merge branch 'MDL-68439-master' of https://github.com/HuongNV13/moodle
Sara Arjona [Thu, 21 May 2020 11:34:59 +0000 (13:34 +0200)]
Merge branch 'MDL-67126_master' of https://github.com/ffhs/moodle
Huong Nguyen [Tue, 28 Apr 2020 10:13:57 +0000 (17:13 +0700)]
MDL-68439 qtype_ddwtos: UI issues
- Fixed cursor for dropped ddwtos
- Fixed the animation of "flying back to the home position" starts off at the right end of the previous line"
Jun Pataleta [Thu, 21 May 2020 09:10:16 +0000 (17:10 +0800)]
Merge branch 'MDL-68367' of https://github.com/mkassaei/moodle
Mahmoud Kassaei [Tue, 14 Apr 2020 09:36:19 +0000 (10:36 +0100)]
MDL-68367 Question: Multi-choice Option to hide systemtext
Sara Arjona [Thu, 21 May 2020 06:30:31 +0000 (08:30 +0200)]
Merge branch 'MDL-68451-master' of git://github.com/cescobedo/moodle
Jun Pataleta [Thu, 21 May 2020 06:26:54 +0000 (14:26 +0800)]
Merge branch 'MDL-68568-master' of git://github.com/junpataleta/moodle
Sara Arjona [Thu, 21 May 2020 06:23:46 +0000 (08:23 +0200)]
Merge branch 'MDL-68782-master' of git://github.com/aanabit/moodle
Adrian Greeve [Thu, 21 May 2020 00:37:52 +0000 (08:37 +0800)]
Merge branch 'MDL-68733' of https://github.com/timhunt/moodle
AMOS bot [Thu, 21 May 2020 00:07:15 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Wed, 20 May 2020 22:51:10 +0000 (00:51 +0200)]
Merge branch 'MDL-52578-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Wed, 20 May 2020 22:45:34 +0000 (00:45 +0200)]
Merge branch 'MDL-66992-master' of https://github.com/tungthai/moodle
Amaia Anabitarte [Wed, 20 May 2020 10:42:11 +0000 (12:42 +0200)]
MDL-68782 core_contentbank: Improving event unit tests
cescobedo [Wed, 20 May 2020 16:50:21 +0000 (18:50 +0200)]
MDL-68451 mod_h5pactivity: Add info attempts in check_updates_since
Add updates information related to attempts in check_updates_since
because they may affect the user or the information displayed
in the app.
Jun Pataleta [Wed, 20 May 2020 16:18:52 +0000 (00:18 +0800)]
MDL-68568 editor_atto: Upgrade step for the new toolbar default layout
* emojipicker added to files
* indent moved to list
Mike Churchward [Thu, 30 Apr 2020 17:20:50 +0000 (13:20 -0400)]
MDL-68568 editor-atto: Move 'indent' next to 'lists' by default.
Víctor Déniz Falcón [Wed, 20 May 2020 14:54:14 +0000 (15:54 +0100)]
Merge branch 'MDL-67183' of git://github.com/timhunt/moodle
Sara Arjona [Wed, 20 May 2020 14:32:36 +0000 (16:32 +0200)]
Merge branch 'MDL-68617-master' of git://github.com/ferranrecio/moodle
Ferran Recio [Fri, 8 May 2020 07:35:41 +0000 (09:35 +0200)]
MDL-68617 mod_h5pactivity: add attempts report webservice
Bas Brands [Wed, 20 May 2020 09:42:55 +0000 (11:42 +0200)]
MDL-68493 core_contentbank: implement list view
Sara Arjona [Wed, 20 May 2020 10:58:37 +0000 (12:58 +0200)]
Merge branch 'MDL-68780' of https://github.com/stronk7/moodle
Amaia Anabitarte [Wed, 20 May 2020 07:25:07 +0000 (09:25 +0200)]
MDL-68782 core_contentbank: Fixing undefined variable error
Ferran Recio [Fri, 8 May 2020 07:34:29 +0000 (09:34 +0200)]
MDL-68617 mod_h5pactivity: add attempt info to generator
Sara Arjona [Wed, 20 May 2020 09:47:27 +0000 (11:47 +0200)]
Merge branch 'MDL-68778-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Wed, 20 May 2020 09:35:08 +0000 (17:35 +0800)]
Merge branch 'MDL-58866-master-2' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Tue, 19 May 2020 21:48:13 +0000 (23:48 +0200)]
MDL-68780 unit tests: Add missing ->destroy() calls to controllers
Every backup and restore controller always need to call
to their ->destroy() method in charge of finalizing loggers,
closing file handlers and destroy some circular references.
This is specially important within unit tests, because
open resources cannot be reset between tests, causing problems,
specially within Windows that locks all those files.
Adrian Greeve [Wed, 20 May 2020 08:52:17 +0000 (16:52 +0800)]
Merge branch 'MDL-68662' of https://github.com/Chocolate-lightning/moodle
Andrew Nicols [Wed, 20 May 2020 08:50:37 +0000 (16:50 +0800)]
Merge branch 'MDL-68577-redis-lock-tuning' of https://github.com/brendanheywood/moodle
Marina Glancy [Wed, 20 May 2020 08:38:12 +0000 (10:38 +0200)]
MDL-58866 core_calendar: deprecation warning in upgrade.txt
Mathew May [Wed, 13 May 2020 03:14:56 +0000 (11:14 +0800)]
MDL-68662 core_course: Add new tabs to the chooser
We now have two more tabs in the chooser.
Activities & Resources aer now offered in different tabs.
Andrew Nicols [Wed, 20 May 2020 00:47:02 +0000 (08:47 +0800)]
MDL-68778 user: Add bulk action pendingjs checks
Brendan Heywood [Sat, 2 May 2020 15:23:32 +0000 (01:23 +1000)]
MDL-68577 session: Fine tune the redis lock polling
Adrian Greeve [Wed, 20 May 2020 05:17:58 +0000 (13:17 +0800)]
Merge branch 'MDL-68333-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Wed, 20 May 2020 00:47:02 +0000 (08:47 +0800)]
MDL-68778 user: Fetch select from selected option
It seems that the HTMLSelectElement behaves slightly different on Linux
vs MacOS.
On Linux with Firefox 47 when selecting an option the
HTMLOptionElement is returned, whereas on MavOS the HTMLSelectElement
that the Option belongs to is returned.
We need to normalise the value here before resetting the currently
selected item.
Jun Pataleta [Wed, 20 May 2020 03:15:22 +0000 (11:15 +0800)]
MDL-68783 core_grades: Fix outcome page's add/remove button styles
* Applied proper styles of btn-secondary.
* Added some vertical spacing between the buttons by enclosing them in
divs with 'm-y-1' class instead of just a br tag.
Nathan Nguyen [Fri, 17 Apr 2020 03:10:26 +0000 (13:10 +1000)]
MDL-39571 repository_recent: query improvement
Nathan Nguyen [Fri, 17 Apr 2020 03:08:22 +0000 (13:08 +1000)]
MDL-39571 repository_recent: add unit test
Jun Pataleta [Sun, 17 May 2020 14:17:30 +0000 (22:17 +0800)]
MDL-52578 core_course: Peer review fixes
* Fetch parent category only when necessary.
* Fix outdated variable names in original patch.
* Fix variable scope for $outcomeexists.
Adrian Greeve [Wed, 20 May 2020 00:35:18 +0000 (08:35 +0800)]
Merge branch 'MDL-67548-master' of https://github.com/kabalin/moodle
AMOS bot [Wed, 20 May 2020 00:07:22 +0000 (00:07 +0000)]
Automatically generated installer lang files
Andrew Nicols [Tue, 19 May 2020 23:32:49 +0000 (07:32 +0800)]
MDL-68464 user: Remove legacy selectall
Eloy Lafuente (stronk7) [Tue, 19 May 2020 22:17:53 +0000 (00:17 +0200)]
Merge branch 'MDL-68464-master-final' of git://github.com/andrewnicols/moodle
Tim Hunt [Fri, 24 Apr 2020 15:12:04 +0000 (16:12 +0100)]
MDL-67183 questions: get_question & get_behaviour only init if required
This reviews all the code code, and sets $requirequestioninitialised
whenever possible in these calls, which should improve performance.
Tim Hunt [Fri, 24 Apr 2020 15:11:51 +0000 (16:11 +0100)]
MDL-67183 question engine: allow lazy-init of question_attempts
That is, we don't call apply_attempt_state as soon as a
the data is loaded from the database. Instead, we wait
and only call it if really needed.
This should (especially after the next commit) be a performance win
during quizzes, particularly for people using advanced question
types liks STACK, or people making extensive use of the
'Try another question like this one' feature.
Víctor Déniz Falcón [Tue, 19 May 2020 19:43:46 +0000 (20:43 +0100)]
Merge branch 'MDL-68299-master' of git://github.com/bmbrands/moodle
Paul Holden [Thu, 22 Aug 2019 16:32:41 +0000 (17:32 +0100)]
MDL-66471 user: fix user_selector debug about extra identity fields.
Steve Bader [Tue, 11 Jun 2019 15:12:35 +0000 (11:12 -0400)]
MDL-52578 core_course: Activity weight set to 0 on creation
Marina Glancy [Mon, 6 Apr 2020 10:36:35 +0000 (12:36 +0200)]
MDL-68333 testing: trigger user_created event in user generator
Marina Glancy [Thu, 30 Apr 2020 16:55:36 +0000 (18:55 +0200)]
MDL-58866 core_calendar: separate color for other events, icons
Marina Glancy [Thu, 30 Apr 2020 10:38:23 +0000 (12:38 +0200)]
MDL-58866 block_timeline: do not display course if abscent
Marina Glancy [Wed, 29 Apr 2020 20:22:10 +0000 (22:22 +0200)]
MDL-58866 core_calendar: allow component events
Sara Arjona [Tue, 19 May 2020 15:54:25 +0000 (17:54 +0200)]
weekly release 3.9dev+
Sara Arjona [Tue, 19 May 2020 15:54:22 +0000 (17:54 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Andrew Nicols [Tue, 19 May 2020 08:27:51 +0000 (16:27 +0800)]
MDL-68463 core_user: Correct Show all link details
Juan Leyva [Tue, 19 May 2020 09:54:53 +0000 (11:54 +0200)]
MDL-68294 tool_mobile: Fix custom strings and limits calculation
Andrew Nicols [Tue, 19 May 2020 08:13:48 +0000 (16:13 +0800)]
Merge branch 'srdjan-slave-conn' of https://github.com/srdjan-catalyst/moodle
Bas Brands [Thu, 2 Apr 2020 13:39:29 +0000 (15:39 +0200)]
MDL-68299 theme_boost: theme updates for accessible zoom
The Moodle UI should be functional in a viewport of 320px by 256px to
meet WCAG 1.4.10
this patch contains improvements to:
-prevent horizontal scrolling
-better wrapping of page header
-message drawer funtional on tiny screens
-remove indenting on courses
-prevent elements overlapping on quiz editing
-better navigation tabs
-fix colour picker
-quiz editing
Srdjan [Tue, 19 May 2020 08:09:14 +0000 (18:09 +1000)]
MDL-19711 dml: call mysqli::real_connect() with @
Juan Leyva [Mon, 18 May 2020 19:20:36 +0000 (21:20 +0200)]
MDL-68294 tool_mobile: Fix key and default apps values
Srdjan [Tue, 19 May 2020 06:21:48 +0000 (16:21 +1000)]
MDL-19711 dml: Fix undefined $dberr
In mysqli_native_moodle_database::raw_connect()
Ferran Recio [Mon, 18 May 2020 16:27:08 +0000 (18:27 +0200)]
MDL-67700 message: correcting conversation timer reset
Andrew Nicols [Thu, 14 May 2020 03:10:57 +0000 (11:10 +0800)]
MDL-68464 enrol_manual: Comment out buggy behat line
This is commented out because auto-hidden toasts currently call `hide()`
and trigger the `bs.toast.hide` event immediately, and _then_ apply the
autohide delay.
Since we automatically add M.util.pending_js calls when we _start_ to
hide, and resolve them when the hide _finishes_, this means that we do:
- addToast called
- trigger `bs.toast.show` event
- add to pending_js
- [pending_js queue not empty - behat waits]
- message is shown in UI
- `hide()` called
- trigger `bs.toast.hide` event
- add to pending_js
- [pending_js queue not empty - behat waits]
- start autohide delay
- [pending_js queue not empty - behat waits]
- [pending_js queue not empty - behat waits]
- [pending_js queue not empty - behat waits]
- [pending_js queue not empty - behat waits]
- end autohide delay
- remove message (no longer present in DOM)
- trigger `bs.toast.hidden` event
- resolve pending_js
- [pending_js queue empty - behat stops waiting]
- Behat runs next step: And I should see "1 enrolled users"
-- Step fails beacuse the message has been shown, and has then been removed
The conversation should have been:
- addToast called
- trigger `bs.toast.show` event
- add to pending_js
- [pending_js queue not empty - behat waits]
- message is shown in UI
- start autohide delay
- trigger `bs.toast.shown` event
- resolve pending_js
- [pending_js queue empty - behat stops waiting]
- Behat runs next step: And I should see "1 enrolled users"
-- Step passes
- autohide delay ends and calls `hide()`
- trigger bs.toast.hide event
- add to pending_js
- [behat waits]
- end autohide delay
- remove message (no longer present in DOM)
- trigger `bs.toast.hidden` event
- resolve pending_js
- [pending_js queue empty - behat stops waiting]
- Behat run continues
See MDL-67386 for futher information.
Andrew Nicols [Mon, 20 Apr 2020 03:24:26 +0000 (11:24 +0800)]
MDL-68464 enrol_manual: Reload participants table after enroling
Andrew Nicols [Mon, 20 Apr 2020 01:24:12 +0000 (09:24 +0800)]
MDL-68464 enrol_manual: Rewrite quickenrolment to use ES6
Andrew Nicols [Tue, 19 May 2020 04:29:20 +0000 (12:29 +0800)]
Merge branch 'srdjan-slave-conn' of https://github.com/srdjan-catalyst/moodle
Jun Pataleta [Tue, 19 May 2020 04:24:14 +0000 (12:24 +0800)]
Merge branch 'MDL-68463-master-3' of git://github.com/andrewnicols/moodle
Andrew Nicols [Tue, 19 May 2020 04:18:15 +0000 (12:18 +0800)]
MDL-68463 user: Show count link should always exist in DOM
Jun Pataleta [Tue, 19 May 2020 03:46:39 +0000 (11:46 +0800)]
Merge branch 'MDL-68528-master' of git://github.com/andrewnicols/moodle
Andrew Nicols [Sun, 26 Apr 2020 07:57:59 +0000 (15:57 +0800)]
MDL-68528 js: Normalise core component for template strings
Andrew Nicols [Sun, 26 Apr 2020 07:57:32 +0000 (15:57 +0800)]
MDL-68528 js: Normalise empty component to "core" for string
Srdjan [Thu, 7 May 2020 04:14:29 +0000 (14:14 +1000)]
MDL-19711 dml: Enable use of readonly slave database handles
Implemented with moodle_read_slave_trait
Functionality is triggered by supplying config dboption['readonly'].
See config-dist.php for more info on supported dboptions.
pgsql and mysqli drivers are using this feature. Also added support for
connection timeout for these two drivers.
AMOS bot [Tue, 19 May 2020 00:07:17 +0000 (00:07 +0000)]
Automatically generated installer lang files